Review Request: Fix color role of tree view lines
Frank Reininghaus
frank78ac at googlemail.com
Thu Oct 25 07:34:47 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107031/#review20834
-----------------------------------------------------------
Ship it!
Thanks Christoph for the patch! Looks good from my point of view and can be pushed to 4.9.
- Frank Reininghaus
On Oct. 24, 2012, 11:02 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107031/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 11:02 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Use the normal text color also for PE_IndicatorBranch (which renders tree lines and arrows).
>
>
> This addresses bug 307734.
> http://bugs.kde.org/show_bug.cgi?id=307734
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf
>
> Diff: http://git.reviewboard.kde.org/r/107031/diff/
>
>
> Testing
> -------
>
> I failed to get correctly rendered tree view lines with Oxygen style. Using other styles, e.g. "-style Skulpture", both the tree view lines and arrows appear correctly colored (WindowText in Folders Panel, Text in main view).
>
> May be an Oxygen problem.
>
>
> Thanks,
>
> Christoph Feck
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121025/f84d793e/attachment.htm>
More information about the kfm-devel
mailing list