Review Request: Make Find a toggle action

[Kai Uwe Broulik]

> On Oct. 24, 2012, 9:21 a.m., Frank Reininghaus wrote:
> > Thanks for the patch and the comments! I think that consistency with other KDE apps is indeed important. Discussing this with usability people sounds like a good idea to me.

Well, imho the Find features in the editor, browsers, etc are finding for contents inside a document, and where you are likely to leave it open for a while and do additional searches and everything, whereas I think in Dolphin you open it, look for something, and close it. Also, and more importantly, Dolphin is one of the few applications that specifically announce the Search features in the toolbar by default, none of the other apps do this. So I think it should be a toggle button, since you have that button in the toolbar by default. 
(Dolphin doesn't use the standard places bar, so much for consistency scnr *duck* :P)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107016/#review20777
-----------------------------------------------------------


On Oct. 23, 2012, 10:07 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107016/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 10:07 p.m.)
> 
> 
> Review request for Dolphin and Frank Osterfeld.
> 
> 
> Description
> -------
> 
> I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview.
> 
> The patch is pretty straight forward.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 7da5801 
>   dolphin/src/dolphinmainwindow.cpp b4a25a7 
> 
> Diff: http://git.reviewboard.kde.org/r/107016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121024/53132e10/attachment.htm>