Review Request: Make Find a toggle action

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107016/#review20776
-----------------------------------------------------------


What about consistency with other KDE and non-KDE applications? like kate, okular, konqueror, rekonq, calligra, firefox, google-chrome, gedit?  I actually can't immediately think of one application using "toggle find" except konsole, but konsole has stopped doing that in the master code (https://git.reviewboard.kde.org/r/105723/).  


Maybe should add usability team into this review ?


- Jekyll Wu


On Oct. 23, 2012, 10:07 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107016/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 10:07 p.m.)
> 
> 
> Review request for Dolphin and Frank Osterfeld.
> 
> 
> Description
> -------
> 
> I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview.
> 
> The patch is pretty straight forward.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 7da5801 
>   dolphin/src/dolphinmainwindow.cpp b4a25a7 
> 
> Diff: http://git.reviewboard.kde.org/r/107016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121024/8feb797e/attachment.htm>