Review Request: Fix Bug 304643 - selected place looks ugly and incomplete

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106827/
-----------------------------------------------------------

(Updated Oct. 17, 2012, 7:42 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Fix Bug 304643 - selected place looks ugly and incomplete

Now the places panel look matches the KFilePlacesView look (the look of Dolphin's Places Panel in KDE <= 4.8).
Also it makes sure that the red color of the "Root" place is preserved (the user who reported this considered the color change distracting).

Additionaly the patch adjusts the look of DolphinView. Now Dolphin uses Text-Area + Icon-Area in Compact- and Detail-View-Mode to determine the
size of the Hover-Background rectangle (Draw rectangle behinde icon + text), in Icon-View-Mode Dolphin only uses the Text-Area (Same as Dolphin 2.1 look).


Description
-------

Fix Bug 304643 - selected place looks ugly and incomplete


This addresses bug 304643.
    http://bugs.kde.org/show_bug.cgi?id=304643


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistwidget.h 55181fa 
  dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d 
  dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 
  dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b 
  dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 
  dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da 

Diff: http://git.reviewboard.kde.org/r/106827/diff/


Testing
-------


Screenshots
-----------

Old and new Dolphin Places look
  http://git.reviewboard.kde.org/r/106827/s/779/


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121017/f0b6742c/attachment.htm>