Review Request: Use better icon for timeline:/ in places

Frank Reininghaus frank78ac at googlemail.com
Tue Oct 16 16:14:27 BST 2012



> On Oct. 16, 2012, 7:32 a.m., Frank Reininghaus wrote:
> > Thanks for the quick reply! I agree that this change makes sense, please go ahead and push to master.
> 
> Xuetian Weng wrote:
>     Should I commit this to KDE/4.9 instead?

Your patch is an improvement, but IMHO not a bug fix, which is why master looks like the right branch to me.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106874/#review20447
-----------------------------------------------------------


On Oct. 15, 2012, 9:04 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106874/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 9:04 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Those are some icon used by korganizer, which looks much better than the same "chronometer".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 4770c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/106874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121016/fcc5e31f/attachment.htm>


More information about the kfm-devel mailing list