Review Request: Use better icon for timeline:/ in places
Frank Reininghaus
frank78ac at googlemail.com
Mon Oct 15 16:46:29 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106874/#review20389
-----------------------------------------------------------
Thanks for the patch! Two quick questions that you might be able to answer faster than me, because I don't have much time to look into this right now:
1. Can you provide "before/after" screenshots?
2. Can we guarantee that those icons are present in every KDE installation? The reason why we used the "chronometer" at all was that the previous icon was distro-specific.
- Frank Reininghaus
On Oct. 15, 2012, 1:29 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106874/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2012, 1:29 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Those are some icon used by korganizer, which looks much better than the same "chronometer".
>
>
> Diffs
> -----
>
> dolphin/src/panels/places/placesitemmodel.cpp 4770c6b
>
> Diff: http://git.reviewboard.kde.org/r/106874/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121015/da43d8d9/attachment.htm>
More information about the kfm-devel
mailing list