Review Request: Fix Bug 304643 - selected place looks ugly and incomplete

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106827/#review20387
-----------------------------------------------------------


First of all, thanks for the patch and the screenshots!

It should be added that the "new" look would match the look of KFilePlacesView, i.e., the look of Dolphin's Places Panel in KDE <= 4.8. In particular, it makes sure that the red color of the "Root" place is preserved (the user who reported this considered the color change distracting, and I agree that it can be considered a bit odd).

However, when we change this, the behaviour of the Places Panel would be different from the one of the DolphinView. This is most obvious when using Details View. I'm not really sure what the best solution is. There are several options:

a) Apply the patch as it is.
b) Only remove the color change, and do not extend the selection rectangle.
c) Don't change anything.
d) Like a), but do the same change in the DolphinView.
e) Like b), but do the same change in the DolphinView.

I'm not entirely sure what the 'right' approach is, but considering that the wish report did not get much feedback, it's not clear if it's really worth adding extra complexity to implement this.

Any other opinions? Do we know how other file managers do it (I don't have any others to test here right now)?


- Frank Reininghaus


On Oct. 15, 2012, 3:26 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 3:26 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 304643 - selected place looks ugly and incomplete
> 
> 
> This addresses bug 304643.
>     http://bugs.kde.org/show_bug.cgi?id=304643
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 
>   dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 
>   dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da 
> 
> Diff: http://git.reviewboard.kde.org/r/106827/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Old and new Dolphin Places look
>   http://git.reviewboard.kde.org/r/106827/s/779/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121015/a981c55f/attachment.htm>