Review Request: Fixed dolphin properties dialog shortcut

[Frank Reininghaus]

> On Oct. 7, 2012, 3:35 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! Looks good and can go into the 4.9 branch :-)
> > 
> > Just one little idea to make it a bit more consistent with the other actions: could you change it slightly to set the multiple shortcuts like it's done for the showHiddenFiles action? With your current approach, the KShortcut which you create with 'primary' and 'alternate' shortcuts is casted to a QList<QKeySequence> implicitly. If you create the QList directly, you save the cast.
> > 
> > It's just a small issue and mostly a matter of taste, but I think that the code will remain more readable if we do it the same way for all actions.
> > 
> > Feel free to push this to the 4.9 branch. If you don't have a git account, just let me know and I'll do it for you. Thanks again for your help!
> 
> Amol Godbole wrote:
>     Thanks for taking the time to review the patch! I agree with your comment and have updated the patch to use QList directly as per your recommendation.  I have tested it too and can confirm that it's working. I do not have a git account currently and so it would be great if you could please push the patch for me. Thank you!

Thanks for the quick update! I've pushed your patch to the 4.9 branch :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106753/#review20040
-----------------------------------------------------------


On Oct. 7, 2012, 5:11 p.m., Amol Godbole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106753/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2012, 5:11 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fixes Bug 307603 - Alt+Enter should open item properties dialog as with Alt+Return, reported by Syam.
> Both Alt+Return and Alt+Enter have now been set as the default shortcuts for the properties dialog in dolphin.
> 
> 
> This addresses bug 307603.
>     http://bugs.kde.org/show_bug.cgi?id=307603
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.cpp 7f23b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/106753/diff/
> 
> 
> Testing
> -------
> 
> Tested and confirmed working with KDE SC 4.9.2 on openSUSE 12.2.
> 
> 
> Thanks,
> 
> Amol Godbole
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121007/0486cce8/attachment.htm>