Review Request: Use the product as text for pluggable/removable devices.

[Alex Fiestas]

> On Oct. 1, 2012, 1:06 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I'm looking forward to seeing meaningful device names in the Places Panel in the future :-)
> > 
> > Looks good, but I have a few little comments, see below.

Finally we will implement this in the libsolid udevbackend, so we can continue using description for all cases.

This was suggested by ervin (former libsolid and kplacesview maintainer) and it makes more sense.

closing the review !


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106639/#review19686
-----------------------------------------------------------


On Sept. 29, 2012, 8:57 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106639/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 8:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Use product instead of description for pluggable/removable devices.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitem.cpp f72f639 
> 
> Diff: http://git.reviewboard.kde.org/r/106639/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> after
>   http://git.reviewboard.kde.org/r/106639/s/747/
> before
>   http://git.reviewboard.kde.org/r/106639/s/748/
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121002/7925b841/attachment.htm>