Review Request: Add support for MTP devices

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106651/#review19688
-----------------------------------------------------------


Thanks for the patch, looks nice! I haven't tried the new mtp kioslave yet, but I'm looking forward to having better access to the data in my phone :-)

I have two little comments, see below.


dolphin/src/panels/places/placesitem.h
<http://git.reviewboard.kde.org/r/106651/#comment15663>

    Please initialise m_mtp in the constructor, to be consistent with the other members.



dolphin/src/panels/places/placesitem.cpp
<http://git.reviewboard.kde.org/r/106651/#comment15664>

    Is that setText() call actually needed if the other patch that you have submitted is applied?


- Frank Reininghaus


On Sept. 30, 2012, 12:42 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106651/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2012, 12:42 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Add support for MTP devices only if the mtp kio slave is installed.
> 
> The patch is prepared to support ptp as well (that's why I put some code into isDeviceSupported). 
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitem.h 5a24a52 
>   dolphin/src/panels/places/placesitem.cpp f72f639 
>   dolphin/src/panels/places/placesitemmodel.h 463e564 
>   dolphin/src/panels/places/placesitemmodel.cpp 4770c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/106651/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121001/2ec53ea5/attachment.htm>