Review Request: Fix bookmarks "Recently Accessed" and "Search for" not available with default install

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107464/#review22656
-----------------------------------------------------------


This review has been submitted with commit 530c743a89bb5366ff9b6f8be1d7a37f23b46880 by Luc Menut to branch master.

- Commit Hook


On Nov. 25, 2012, 7:24 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107464/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 7:24 p.m.)
> 
> 
> Review request for Dolphin, Vishesh Handa, Peter Penz, and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The bookmarks for "Recently Accessed" and "Search for" is not available in dolphin after a default install, since git rev. f5b6fbf7
>   https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/f5b6fbf7747cefceef4bcd31d90d053da5c560c4
> 
> With a default install, indexing is enabled by default and [Service-nepomukfileindexer]autostart is not written in nepomukserverrc.
>   https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/nepomuk/kcm/nepomukserverkcm.cpp#L216
> 
> Because in dolphin, placesitemmodel.cpp line 93 
>   m_fileIndexingEnabled = config.group("Service-nepomukfileindexer").readEntry("autostart", false)
> default to false if [Service-nepomukfileindexer]autostart is missing, m_fileIndexingEnabled is false by default even if indexing is available.
> 
> m_fileIndexingEnabled should follow the default value (true) of nepomukserverkcm m_checkEnableFileIndexer.
> 
> The suggested patch fixes this issue.
> 
> regards,
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp a37c17f 
> 
> Diff: http://git.reviewboard.kde.org/r/107464/diff/
> 
> 
> Testing
> -------
> 
> tested with KDE 4.9.80 (Mageia Cauldron)
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121127/ecb358f7/attachment.htm>