Review Request: Fix Bug 310465 - Can't switch view mode for non-writable paths

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107458/#review22532
-----------------------------------------------------------


This review has been submitted with commit 56407d94bf8b91bcf1b0a5b37f33d29babb5a9fd by Emmanuel Pescosta to branch KDE/4.9.

- Commit Hook


On Nov. 25, 2012, 3:06 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107458/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 3:06 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 310465 - Can't switch view mode for non-writable paths
> 
> Check also if the .directory file is writable, not only the parent folder.
> 
> 
> This addresses bug 310465.
>     http://bugs.kde.org/show_bug.cgi?id=310465
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/viewproperties.cpp ff0c274 
> 
> Diff: http://git.reviewboard.kde.org/r/107458/diff/
> 
> 
> Testing
> -------
> 
> Tested with:
> 1. Not-Writable Folder
> 2. Not-Writable .directory File but writable Folder
> 3. Writable Folder and writable .directory File (Normal case)
> 
> Works fine for me in all three cases ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121125/db793636/attachment.htm>