Review Request: Fix Bug 310465 - Can't switch view mode for non-writable paths

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107458/
-----------------------------------------------------------

(Updated Nov. 25, 2012, 3:06 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Check if the Folder is writable -> If writable: Check if the ".directory" File exists and is writable

Previous patch introduced a regression with folders, without ".directory" files. (It worked but the View Settings were not saved in the right folder - Dolphin handled them like non-writable folders)


Description
-------

Fix Bug 310465 - Can't switch view mode for non-writable paths

Check also if the .directory file is writable, not only the parent folder.


This addresses bug 310465.
    http://bugs.kde.org/show_bug.cgi?id=310465


Diffs (updated)
-----

  dolphin/src/views/viewproperties.cpp ff0c274 

Diff: http://git.reviewboard.kde.org/r/107458/diff/


Testing
-------

Tested with:
1. Not-Writable Folder
2. Not-Writable .directory File but writable Folder
3. Writable Folder and writable .directory File (Normal case)

Works fine for me in all three cases ;)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121125/2cf6a225/attachment.htm>