Review Request: Update the 'isCut' state of items in the view if, e.g., text is copied to the clipboard

[Frank Reininghaus]

> On Nov. 24, 2012, 3:03 p.m., Commit Hook wrote:
> > This review has been submitted with commit 4120805872c2e9fac909a403b83221c09c9110a2 by Frank Reininghaus to branch KDE/4.9.
> 
> Christoph Feck wrote:
>     Not really sure if caused by this commit, but on today's master, I get "cut" items (rendered gray), even when I only copy them. Is this intended?
> 
> Frank Reininghaus wrote:
>     Thanks Christoph for testing and reporting this! Yes, this stupid regression has been caused by my commit. I think the best solution is to revert the function to the old state and add an 'else' branch that clears m_cutItems and emits the signal.

Should be working now in both KDE/4.9 and master.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107390/#review22481
-----------------------------------------------------------


On Nov. 19, 2012, 9:20 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107390/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 9:20 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Right now, we only update the "isCut" state of file items when other files are copied or cut to the clipboard. The expected behaviour is to make the items look "uncut" also when some non-file thing, like, e.g., text, is cut or copied.
> 
> The complexity of the previous code which I'm proposing to remove makes me wonder if there could be any problem with this approach - does anyone see anything that might go wrong?
> 
> (Yes, I do know that KUrl::List::fromMimeData() is deprecated and that I should be using KUrlMimeData::urlsFromMimeData() instead. It seems that kdelibs doesn't install the required header here, I'll look into that, unless the reason is that I'm doing somthing wrong, in which case I'd appreciate feedback about that).
> 
> 
> This addresses bug 304615.
>     http://bugs.kde.org/show_bug.cgi?id=304615
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kfileitemclipboard.cpp 6d60856 
> 
> Diff: http://git.reviewboard.kde.org/r/107390/diff/
> 
> 
> Testing
> -------
> 
> Works for me, no regressions seen so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121125/9e5d2955/attachment.htm>