Review Request: Proposal to add a 'lock toggle button' to filter bar to prevent clearing of filter when navigating to a different folder

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107392/#review22265
-----------------------------------------------------------



dolphin/src/dolphinmainwindow.h
<http://git.reviewboard.kde.org/r/107392/#comment17129>

    Is it possible to move this line to dolphinmainwindow.cpp and write "class DolphinView;" instead?



dolphin/src/dolphinmainwindow.h
<http://git.reviewboard.kde.org/r/107392/#comment17118>

    Please avoid/remove trailing spaces. 
    
    If you use KDevelop, you can activate "Remove trailing spaces while editing" and "Remove trailing spaces on save".



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17119>

    if( m_activeViewContainer != 0 ) {
    
    }
    
    Better write:
    if (m_activeViewContainer) {
    
    }



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17120>

    if( m_activeViewContainer != 0 ) {
    
    }
    
    Better write:
    if (m_activeViewContainer) {
    
    }



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17121>

    Please remove trailing spaces



dolphin/src/dolphinviewcontainer.h
<http://git.reviewboard.kde.org/r/107392/#comment17122>

    Please remove trailing spaces.



dolphin/src/dolphinviewcontainer.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17123>

    Please revert this change to Q_ASSERT(m_filterBar);



dolphin/src/dolphinviewcontainer.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17124>

    Please remove != 0



dolphin/src/dolphinviewcontainer.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17125>

    Please remove != 0



dolphin/src/filterbar/filterbar.h
<http://git.reviewboard.kde.org/r/107392/#comment17126>

    Please remove trailing spaces



dolphin/src/filterbar/filterbar.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17131>

    Please use #include <KToolBar> instead



dolphin/src/filterbar/filterbar.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17127>

    Please remove trailing spaces



dolphin/src/filterbar/filterbar.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17130>

    if( m_lockTextAction->isChecked() == false) {
    
    Please write
    if (!m_lockTextAction->isChecked()) {



dolphin/src/filterbar/filterbar.cpp
<http://git.reviewboard.kde.org/r/107392/#comment17128>

    Please add { } brackets
    
    
    if(checked == false) {
    
    Please write:
    if (!checked) {


- Emmanuel Pescosta


On Nov. 20, 2012, 5:16 a.m., Stuart Citrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107392/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 5:16 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I wrote a quick add-on for the Dolphin filter bar.   It is a button which prevents the filter text from clearing when navigating to a different folder. 
> 
> Why this might be needed:
> 
> This is an attempt to resolve the following usability conflict: 
> 
> If one navigates to a different folder, the filter is automatically cleared since one does not want a situation where someone forgets a filter is applied and then doesn't understand why all the files within a folder are not appearing.(current behavior) 
> versus: 
> A user might want to keep a filter while navigating an arbitrary set of folders, but is unable to, since the filter is automatically cleared upon navigation 
> 
> The implementation to try to resolve this conflict is as follows: 
> 
> 1. A lock filter toggle button is added to the right side of the filter bar. 
> 2. If the lock filter button is clicked(on), then if the user navigates away from the current folder, the filter is not cleared. If the lock filter button is released(off), then the text is cleared on navigation...which is the current behavior. 
> 3. A configurable shortcut is added to toggle the lock filter button, with the default being Ctrl-Shift-I (since the default shortcut for hiding and showing the filter bar is Ctrl-I.) 
> 4. If the user toggles the lock filter button to released (off), then the text in the filter also clears. The assumption here is that if the user no longer wants the text to be locked, he probably also wants to clear the text.
>  5. When the filter bar is hidden, then the lock filter button is released. The next time the filter bar is shown, the lock filter button will be in the released(off) position and the filter text will have been cleared. 
> 6. At application startup, the lock filter button is always off, and the filter bar text cleared. 
> 
> This also fixes a current bug in dolphin where one is unable to toggle the visibility of the filter bar using the tool bar filter button, or by using the assigned hot key.
> 
> Note... I think it is 'patch -p2' from the "dolphin" directory (above src directory ) to apply the patch
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 7da5801 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
>   dolphin/src/dolphinviewcontainer.h 0300273 
>   dolphin/src/dolphinviewcontainer.cpp 6e99437 
>   dolphin/src/filterbar/filterbar.h 9546c63 
>   dolphin/src/filterbar/filterbar.cpp f3076f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107392/diff/
> 
> 
> Testing
> -------
> 
> Went through all paths in dolphin.  Tested: 1. Navigate to different folder. Text should clear only when text not locked
> 2.Ctl-I shortcut to toggle visiblility of filterbar
> 3.Text clears when filterbar hidden and then shown
> 4. Lock button locks and unlocks text
> 5. Shift-Ctl-I shortcut to toggle lock status of text.  Lock button updates appropriately
> 6. Status (with non-perisistence from previous instance) of lock button when starting application..i.e. lock status is off on startup
> 7. Change keyboard shortcuts...works appropriately
> 8. F3 and split view..tabs..etc.. should still work appropriately
> 9. Monkey tested...cannot get it to crash
> etc....
> 
> 
> Thanks,
> 
> Stuart Citrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121120/d5fb01db/attachment.htm>