Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107305/#review21915
-----------------------------------------------------------


Thanks Emmanuel! The idea looks good, but I see one little issue that we should think about: note that the DolphinView might be embedded in a DolphinPart in Konqueror - we also want to behave nicely in that case. In Konqueror, one can choose (by modifying the settings) to open files like, e.g., images, PDFs or whatever in an embedded viewer inside Konqueror.

With your patch, Konqueror opens multiple images in a single Gwenview instance, which is certainly better than the current behaviour (open the last image that the itemActivated() signal has been received for in Konqueror and forget about the rest), but I'm not sure if that is the wanted behaviour.

@David, Dawit: can you provide some feedback about this? If the user selects multiple images and presses Enter, should those images be opened in an external application (e.g., Gwenview), or in new tabs in Konqueror?

- Frank Reininghaus


On Nov. 12, 2012, 10:44 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107305/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 10:44 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected
> 
> 
> This addresses bug 304299.
>     http://bugs.kde.org/show_bug.cgi?id=304299
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp df49634 
> 
> Diff: http://git.reviewboard.kde.org/r/107305/diff/
> 
> 
> Testing
> -------
> 
> Tested with Gwenview, works fine.
> 
> # Dolphin 2.1: Start one Gwenview instance for each selected image
> # Patched Dolphin: Open all selected images in one Gwenview instance
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121113/a6d0f15a/attachment.htm>