Review Request: Fix Bug 304643 - selected place looks ugly and incomplete

[Frank Reininghaus]

Hi everyone,

2012/11/11 Mark:
>
> Would you mind responding inside the review request? Just so that everything is in one place.
> http://git.reviewboard.kde.org/r/106827/

I think that we have to discuss this in a more structured way, or this
discussion will not lead anywhere. First, we should discuss the look -
how to do it in the code is only the second step.

The question is: what should a selected item look like? We currently
use two things to make it clear that something is selected:

a) The name of the item gets a blue background (at least when using
the default settings).
b) The icon is 'tinted', i.e., gets a different color.

AFAIK, the 'tinting' was added mostly to make it more obvious that an
item is selected in Icons View (where the icon often takes way more
space than the name). However, based on the  feedback that we got so
far, I think that the tinting is too strong.

Some ideas what could be done to make it better:

1. Make the tinting weaker in all view modes or in Icons View only.
2. Remove the tinting completely, and (possibly) extend the 'blue
background' in Icons View to include also the icon.
3. Restore the Dolphin 1.x behaviour (as far as I remember: no
tinting, 'blue background' includes icon+name in all view modes).

It might help if someone could create screenshots of all 3 view modes
(Icons, Details, Compact [which you can get also in Dolphin 1.7 by
tweaking the 'Icons Mode' settings]) and the Places Panel using the
default settings and icon sizes  for Dolphin 1.7 and the current
version, put that together to one or two images, and attach that here
to make it easier to discuss about the different looks. I don't have
much time for that currently, just trying to answer a couple of
e-mails before getting back to work.

If there is agreement that something should be changed, I'd prefer if
it was done at least before the Beta 2 tagging (Nov 29) to get
sufficient feedback before the next stable release. Beta 1 (Nov 15)
might be too close already.

Best regards,
Frank