Review Request: Feature Request - Show full path in title bar

[Hrvoje Senjan]

> On Nov. 9, 2012, 11:02 p.m., Frank Reininghaus wrote:
> > Thanks for taking the time to implement this, but considering that only two people expressed interest in such a feature (one of them in 2004, when Dolphin didn't exist at all), I'm not sure if this feature is really useful enough to justify that we add code and a GUI option to implement it. Every option makes the settings dialog a bit more complex and harder to use, therefore, I prefer to only add options if I see that there is a very good reason to do it.
> > 
> > If some feature request has been reported at bugs.kde.org, that does not necessarily mean that it should be implemented, not even if it's marked as NEW. I'm sorry if there was a misunderstanding there! Note that bugs can be confirmed in several ways, one of them is by getting a certain number of votes. I think that Peter's policy was to confirm wish reports when it seemed sort of understandable that the feature might be useful to the reporter (which does not necessarily mean that the feature is in agreement with http://dolphin.kde.org/philosophy.html).
> > 
> > One could argue that we should close reports which are probably not going to be implemented as WONTFIX, but going through all wish reports, evaluating one by one if they make sense and then writing something reasonable to make it clear to the reporter why we are not going to implement it would take an enormous amount of time. Moreover, it would not be a very productive task. Therefore, I'm neither willing to spend the little time that I have to work on Dolphin on that, nor will I ask someone else to help with that. Yes, the "feature requests at bugs.kde.org" situation is very far from optimal, but I don't see a way to resolve this :-(
> 
> Emmanuel Pescosta wrote:
>     > Every option makes the settings dialog a bit more complex and harder to use, therefore, I prefer to only add options if I see that there is a very good reason to do it
>     Yes, I agree with you.
>     
>     A possible solution for this problem:
>     # Situation:
>      You have opened multiple tabs - /home/kdeuser/dolphin/src, /home/kdeuser/kdelibs/src and /home/kdeuser/kate/src
>     # Tabs in Dolphin 2.1:
>      | src | src | src |
>     # Tabs in a "possible" Dolphin version (Current tab name is also used for the window title):
>      | dolphin/src | kdelibs/src | kate/src |
>     
>     Dolphin does automatically recognize if there are multiple tabs with the same name. -> The problem is automatically solved (So we need no additional gui option) -> Very useful feature for the Dolphin user Simon ;)
>     
>     Do you like this idea?
>     
>     > http://dolphin.kde.org/philosophy.html
>     Interesting :)
>     
>     > One could argue that we should close reports which are probably not going to be implemented as WONTFIX, but ....
>     Hmm, how could we handle that in a good way? - What if we create a list of interesting and useful feature request (also with "priority" and additional ideas), so that every Dolphin developer can work on some cool features, which agree with the Dolphin philosophy and get definitely merged into master.
>     
>     It would be great, if we can setup a wiki or forum for that purpose (Like KDE brainstorm but Dolphin specific)
>     
>     A "possible" way to create very usable features would be:
>     1. Search for interesting feature requests with the "same" target/scope - "Merge" multiple feature requests (Work together on IRC with developers and users)
>     2. Think about it!!! (Work together on IRC with developers and users)
>     3. Write a wiki/forum article about it and add mock-ups, personal ideas, implementation details, possible usecases ... (Work together on IRC with developers and users)
>     4. Other developers/users/ui-experts/... can now give their feedback about it (additional ideas, better mock-ups, better way to implement the feature, ...)
>     5. Developers who are interested in this feature start to implement it
>     6. Other developers/users/experts can now test the feature -> feedback
>     7. Merge it into master and ship it 
>     8. HAVE FUN WITH A NEW AWESOME (and well studied) FEATURE ;)
> 
> Mark Gaiser wrote:
>     I actually changed the titlebar a few releases ago. Please look at this review from back then. https://svn.reviewboard.kde.org/r/5178/
>     
>     Showing the full path in the dolphin decorations is not really desirable from my point of view.
> 
> Emmanuel Pescosta wrote:
>     Thanks for your reply :)
>     
>     Btw. what do you think about my idea C#2?
>     
>     # Situation:
>      You have opened multiple tabs - /home/kdeuser/dolphin/src, /home/kdeuser/kdelibs/src and /home/kdeuser/kate/src
>     # Tabs in Dolphin 2.1: (=> hmm which folder belongs to dolphin? kdelibs? kate??)
>      | src | src | src |
>     # Tabs in a "possible" Dolphin version: (always clear which src folder belongs to which project)
>      | dolphin/src | kdelibs/src | kate/src |
>     
>     Another example: A web developer uses Dolphin for ftp transfer (The webserver and the local pc have the same folder structure) 
>     # Dolphin 2.1: 
>      | image | image | (Hmm which image folder is on the server/local pc?)
>     # "Patched" Dolphin: 
>      | Developing/website/images | Server/website/images |
>     
>     I think this is very useful feature for Dolphin users (Developers, photographers, admins, ...). Am I wrong?

> I think this is very useful feature for Dolphin users (Developers, photographers, admins, ...). Am I wrong?

I completely agree! Also, i have tested your patch and it works quite nicely :-) If not commited, it will certainly be handy to have it.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107268/#review21745
-----------------------------------------------------------


On Nov. 9, 2012, 6:59 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107268/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 6:59 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Patch for feature requests: 
> + 88177 - Title bar and tabs in file management display only directory basename 
> + 229810 - Show full path in title bar
> 
> 
> This addresses bugs 88177 and 229810.
>     http://bugs.kde.org/show_bug.cgi?id=88177
>     http://bugs.kde.org/show_bug.cgi?id=229810
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
>   dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7 
>   dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
> 
> Diff: http://git.reviewboard.kde.org/r/107268/diff/
> 
> 
> Testing
> -------
> 
> Works for me
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121111/3ff2f256/attachment.htm>