Review Request: Fix Bug 304643 - selected place looks ugly and incomplete

[Emmanuel Pescosta]

> On Nov. 10, 2012, 4:24 p.m., Nuno Bento wrote:
> > Hey there! I believe Frank meant Nuno Pinheiro, not me. :)
> > 
> > But if I may, I'd like to chime in and say that I personally think the patched version looks better.

Oh sorry ... but thanks for your reply ;)

Hmm I can't find Nuno Pinheiro on reviewboard??


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106827/#review21776
-----------------------------------------------------------


On Nov. 9, 2012, 9:55 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 9:55 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Nuno Bento.
> 
> 
> Description
> -------
> 
> Fix Bug 304643 - selected place looks ugly and incomplete
> 
> 
> This addresses bug 304643.
>     http://bugs.kde.org/show_bug.cgi?id=304643
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.h 55181fa 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 
>   dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b 
>   dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 
>   dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da 
> 
> Diff: http://git.reviewboard.kde.org/r/106827/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Old and new Dolphin Places look
>   http://git.reviewboard.kde.org/r/106827/s/779/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121110/959f1d76/attachment.htm>