Review Request: Feature Request - Show full path in title bar

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107268/#review21745
-----------------------------------------------------------


Thanks for taking the time to implement this, but considering that only two people expressed interest in such a feature (one of them in 2004, when Dolphin didn't exist at all), I'm not sure if this feature is really useful enough to justify that we add code and a GUI option to implement it. Every option makes the settings dialog a bit more complex and harder to use, therefore, I prefer to only add options if I see that there is a very good reason to do it.

If some feature request has been reported at bugs.kde.org, that does not necessarily mean that it should be implemented, not even if it's marked as NEW. I'm sorry if there was a misunderstanding there! Note that bugs can be confirmed in several ways, one of them is by getting a certain number of votes. I think that Peter's policy was to confirm wish reports when it seemed sort of understandable that the feature might be useful to the reporter (which does not necessarily mean that the feature is in agreement with http://dolphin.kde.org/philosophy.html).

One could argue that we should close reports which are probably not going to be implemented as WONTFIX, but going through all wish reports, evaluating one by one if they make sense and then writing something reasonable to make it clear to the reporter why we are not going to implement it would take an enormous amount of time. Moreover, it would not be a very productive task. Therefore, I'm neither willing to spend the little time that I have to work on Dolphin on that, nor will I ask someone else to help with that. Yes, the "feature requests at bugs.kde.org" situation is very far from optimal, but I don't see a way to resolve this :-(

- Frank Reininghaus


On Nov. 9, 2012, 6:59 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107268/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 6:59 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Patch for feature requests: 
> + 88177 - Title bar and tabs in file management display only directory basename 
> + 229810 - Show full path in title bar
> 
> 
> This addresses bugs 88177 and 229810.
>     http://bugs.kde.org/show_bug.cgi?id=88177
>     http://bugs.kde.org/show_bug.cgi?id=229810
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
>   dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7 
>   dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
> 
> Diff: http://git.reviewboard.kde.org/r/107268/diff/
> 
> 
> Testing
> -------
> 
> Works for me
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121109/8571155c/attachment.htm>