Review Request: Fix Bug 304643 - selected place looks ugly and incomplete

[Frank Reininghaus]

> On Nov. 6, 2012, 1:10 a.m., Mark Gaiser wrote:
> > Any update on this? I like how it looks when patched :)
> 
> Emmanuel Pescosta wrote:
>     Nope not really ... waiting for "ship it" (or "discard it") ;)

Well, as I said, I really have no clue what the best solution is from a design or usability point of view. Based on feedback that we got recently, I think now that the 'tinting' of the icons of selected items is too strong and might have to be weakened, but apart from that, I really don't have a strong opinion on this, which is why I think that it might help to add Nuno and/or other people or groups with design or usability knowledge to this review request. AFAIK, this can be done only by Emmanuel.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106827/#review21471
-----------------------------------------------------------


On Oct. 17, 2012, 7:42 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 7:42 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 304643 - selected place looks ugly and incomplete
> 
> 
> This addresses bug 304643.
>     http://bugs.kde.org/show_bug.cgi?id=304643
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.h 55181fa 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 
>   dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b 
>   dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 
>   dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da 
> 
> Diff: http://git.reviewboard.kde.org/r/106827/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Old and new Dolphin Places look
>   http://git.reviewboard.kde.org/r/106827/s/779/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121109/e2527060/attachment.htm>