Review Request: Fix Bug 217575 - Auto select pasted files doesn't select all files if some have been skipped

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107237/#review21637
-----------------------------------------------------------


Thanks for the new patch! Looks good, except for one thing: I don't quite get the point of the markUrlAsCurrent(KUrl()) call. Under normal circumstances, this should have no effect at all because m_currentItemUrl is set to KUrl() anyway when loading the folder is finished. However, I think that this might destroy the "restore current item when going 'back'" feature, right?

- Frank Reininghaus


On Nov. 8, 2012, 11:48 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107237/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2012, 11:48 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 217575 - Auto select pasted files doesn't select all files if some have been skipped
> 
> 
> This addresses bug 217575.
>     http://bugs.kde.org/show_bug.cgi?id=217575
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp e2ccc7f 
> 
> Diff: http://git.reviewboard.kde.org/r/107237/diff/
> 
> 
> Testing
> -------
> 
> Patch passes all Selection-Manager Tests
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121108/85decba5/attachment.htm>