Review Request: Fix Bug 217575 - Auto select pasted files doesn't select all files if some have been skipped

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107237/#review21612
-----------------------------------------------------------


Thanks Emmanuel! In principle, I think that the idea is very good. However, if we do not clear the set m_selectedUrls, there is a small problem: Imagine that you paste items to a folder ~/a, such that they are selected. If you now go back to ~ and then click the folder ~/a again, the items will be selected again, which should actually not happen. Moreover, if you delete one of these pasted items from the Terminal Panel and recreate it using touch, it will be selected again.

Maybe this could be resolved by removing a URL from the set if it has been selected sucessfully? Moreover, I'm wondering if it also makes sense to clear the set in DolphinView::setUrl(), just to be sure that no URLs stay there forever if pasting an item failed for some reason.

- Frank Reininghaus


On Nov. 7, 2012, 11:49 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107237/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 11:49 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 217575 - Auto select pasted files doesn't select all files if some have been skipped
> 
> 
> This addresses bug 217575.
>     http://bugs.kde.org/show_bug.cgi?id=217575
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp e2ccc7f 
> 
> Diff: http://git.reviewboard.kde.org/r/107237/diff/
> 
> 
> Testing
> -------
> 
> Patch passes all Selection-Manager Tests
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121108/ef5671eb/attachment.htm>