Do we need: A folder cannot be dropped into itself

[Peter Penz]

On 05/28/2012 09:47 PM, Alex Fiestas wrote:
> On Monday, May 28, 2012 09:32:43 PM Peter Penz wrote:
>> On 05/28/2012 08:44 PM, Alex Fiestas wrote:
[...]
>> Sorry, I but did not understand your suggestion: If the users drops
>> folder A into A - what should be done here instead of showing the
>> error-message?
> Nothing, the folder will still be selected and nothing should happen.

OK.

>>   >  Maybe in that case we could
>>   >  move everything into the folder besides the error?
>>
>> But folder A contains already everything - what should be moved?
> If we have selected folder A and files B C, then we drop A,B,C into A files B
> and C should be moved into A.

OK, I understand now. But I'm not really sure if just copying B and C 
without any feedback should be done. We assume here that the user 
accidentally selected folder A, but it might also possible that the user 
accidentally has hovered the wrong folder when dropping.

Lets assume the user intended to drop A, B and C into the folder A0 and 
not A, but accidentally dropped it to folder A. Now if we just move B, 
and C into A, the user might not even notice that nothing has been moved 
into A0: Dolphin will say "Moving finished" without any feedback that 
the folder "A" has been ignored.

Before discussing this in more detail, I think the best solution would 
anyhow be different: Instead of showing an error-message _after_ the 
dropping has been done, a "you-cannot-drop-here"-sign _during_ dropping 
might be better.

I planned to implement this for 4.9 already but had some troubles to 
change the cursor during dragging with QGraphicsView... Should be no big 
deal I think, but currently there are still other more important issues 
to fix ;-)

> Basically in my humble opinion dropping A into A is an obvious mistake and the
> user shouldn't be noticed of it.
>
> I know 0 about usability and such, but I fail to see how the "A folder cannot
> be dropped into itself" can be helpful.