Review Request: Patch for dolphin that disables trash on removable media drives

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104915/#review13715
-----------------------------------------------------------


Thanks for the patch, but based on the discussion at bug 188032 I'm not convinced that this should go in... I'd even go that far to question the current check whether the file is local in DolphinContextMenu::moveToTrash()...

Before writing such (rather large) patches I always recommend to check with the maintainers first, whether such a change of behavior is really wanted.

For Dolphin 2.1 I'll remove the is-local-check in DolphinContextMenu::moveToTrash() - if I'm really wrong the feedback on bugs.kde.org will show this. In this case I'll revert my change (and I'm also sure David Faure might agree then) and will also include your patch then if this is OK for you.

- Peter Penz


On May 11, 2012, 9:31 a.m., Alexander Skakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104915/
> -----------------------------------------------------------
> 
> (Updated May 11, 2012, 9:31 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Patch for dolphin that disables trash on removable media drives. When user opens context menu on file located on the removable media, "Move to trash" item is replaced with "Delete" item as well as "Del" keyboard shortcut executes "Delete" action instead of "Move to trash". Same behavior is already used for remote file systems, this patch just extends it for local but removable storages.
> I can modify it to be optional if there is a need for this
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt c00d29c 
>   dolphin/src/dolphincontextmenu.cpp 286d304 
>   dolphin/src/views/dolphinview.h b2c4121 
>   dolphin/src/views/dolphinview.cpp 6a21885 
>   dolphin/src/views/dolphinviewactionhandler.cpp 7f23b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/104915/diff/
> 
> 
> Testing
> -------
> 
> On various USB flash disks, card readers, external USB HDD drives
> 
> 
> Thanks,
> 
> Alexander Skakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120511/ab605297/attachment.htm>