Review Request: Open new window with KRun::runUrl (with MIME-type inode/directory) instead of KRun::run fixes bug 274655 and bug 292822.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105584/#review16086
-----------------------------------------------------------


Indeed, %u didn't work, due to a bug in KRun (kdelibs).

I have now fixed that bug, and committed the %u additions.

You said:
> I my mind, the default filemanager problem doesn't really make a sense, because when somebody has set another filemanager as default filemanager, than he will not use dolphin.

But this isn't 100% correct. Someone with another filemanager as default, could be using dolphin in order to test it before making it default, or for a very specific task that dolphin handles best. I agree, a bit of a corner case, but no reason to introduce new bugs nonetheless.

Please mark this review request as discarded, if you agree with my fix.

- David Faure


On July 15, 2012, 7:23 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105584/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 7:23 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Open new window with KRun::runUrl (with MIME-type inode/directory) instead of KRun::run fixes bug 274655 and bug 292822.
> 
> 
> This addresses bugs 274655 and 292822.
>     http://bugs.kde.org/show_bug.cgi?id=274655
>     http://bugs.kde.org/show_bug.cgi?id=292822
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 1ce5193 
> 
> Diff: http://git.reviewboard.kde.org/r/105584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120718/a0c15fb1/attachment.htm>