Review Request: 303375 - Dots in directory names treated as file extension

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105575/
-----------------------------------------------------------

(Updated July 18, 2012, 5:17 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Consistent &-placement in dolphin/src/kitemviews/kfileitemlistwidget.h line 55 and dolphin/src/kitemviews/kstandarditemlistwidget.h line 145

One small comment: please write selectionLength rather than selectionLen. => I wrote textSelectionLength because the Function is called selectionLength

ready for commit?
and thank you for your reviews :) - I will do it right in the next commit


Description
-------

bug fix for 303375 - Dots in directory names treated as file extension 


This addresses bug 303375.
    http://bugs.kde.org/show_bug.cgi?id=303375


Diffs (updated)
-----

  dolphin/src/kitemviews/kfileitemlistwidget.h b0d8e1c 
  dolphin/src/kitemviews/kfileitemlistwidget.cpp c99da38 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 222d7b5 
  dolphin/src/kitemviews/kstandarditemlistwidget.cpp e584c06 
  dolphin/src/views/renamedialog.cpp e232b96 

Diff: http://git.reviewboard.kde.org/r/105575/diff/


Testing
-------


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120718/fe60b97e/attachment.htm>