Review Request: Open new window with KRun::runUrl (with MIME-type inode/directory) instead of KRun::run fixes bug 274655 and bug 292822.

[David Faure]

> On July 16, 2012, 3:07 p.m., David Faure wrote:
> > I see. The problem with the old code was that the exec line was "dolphin" and not "dolphin %u" so KRun thought non-local URLs were not supported, so it would trigger kioexec ("download and open") which doesn't make sense for directories.
> > 
> > The new code, instead, says "open this with the default file manager", which might not always be wanted, if the default file manager is set to something else than dolphin?
> > 
> > If "open in new window" should always open a dolphin window and not anything else, then the fix would be to replace "dolphin" with "dolphin %u". Can you give this a try?
> 
> Christoph Feck wrote:
>     Doesn't the service/desktop file for dolphin already state that dolphin accepts an url?

Yes, but then you need to pass a KService to KRun, not an exec command line :)

However, relying on finding the right .desktop file on the system is a bit too brittle to my test (I've seen breakage happen due to that), so better write %u than rely on that.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105584/#review15960
-----------------------------------------------------------


On July 15, 2012, 7:23 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105584/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 7:23 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Open new window with KRun::runUrl (with MIME-type inode/directory) instead of KRun::run fixes bug 274655 and bug 292822.
> 
> 
> This addresses bugs 274655 and 292822.
>     http://bugs.kde.org/show_bug.cgi?id=274655
>     http://bugs.kde.org/show_bug.cgi?id=292822
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 1ce5193 
> 
> Diff: http://git.reviewboard.kde.org/r/105584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120716/cc78f190/attachment.htm>