Review Request: 303375 - Dots in directory names treated as file extension

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105575/#review15955
-----------------------------------------------------------


Thanks for the patch, looks very good from my point of view!

I cannot test it myself at the moment, therefore, I'd appreciate it if someone else could verify independently that your patch works and does not break anything else. It seems unlikely, but I want to make sure that there are no regressions so short before the 4.9.0 release.

One small comment: please write selectionLength rather than selectionLen.

- Frank Reininghaus


On July 14, 2012, 11:45 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105575/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 11:45 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> bug fix for 303375 - Dots in directory names treated as file extension 
> 
> 
> This addresses bug 303375.
>     http://bugs.kde.org/show_bug.cgi?id=303375
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistwidget.h b0d8e1c 
>   dolphin/src/kitemviews/kfileitemlistwidget.cpp c99da38 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 222d7b5 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp e584c06 
>   dolphin/src/views/renamedialog.cpp e232b96 
> 
> Diff: http://git.reviewboard.kde.org/r/105575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120716/7cdfbaef/attachment.htm>