Review Request: Make PageUp/PageDown work in Dolphin's new view engine

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103721/#review9912
-----------------------------------------------------------

Ship it!


Thanks Frank! I agree, this really is a bugfix that should go into 4.8.0 and as the tagging happens today, I'd say: ship it :-)

- Peter Penz


On Jan. 18, 2012, 8:27 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103721/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 8:27 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I think this is one of the last things that should be fixed for 4.8.0. I had to add a new parameter 'index' to nextRowIndex() and previousRowIndex() to be able to reuse these methods for the PageUp/PageDown actions, which are performed by calling these methods repeatedly until the index with the target Y coordinate is reached.
> 
> The algorithm used to determine the new current index is a quick hack of mine, but I think it mostly does what Qt's itemviews do (at least in Icons View).
> 
> 
> This addresses bug 288748.
>     http://bugs.kde.org/show_bug.cgi?id=288748
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.h d0e5f72 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp fedbe61 
> 
> Diff: http://git.reviewboard.kde.org/r/103721/diff/diff
> 
> 
> Testing
> -------
> 
> Works like PageUp/PageDown in Qt's itemviews with the following exception: In Details View, it does not take the header height into account.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120118/1ad609cf/attachment.htm>