Review Request: If multiple items are selected and one of them is clicked to trigger it, deselect the other items

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103703/#review9855
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks fine :-)

- Peter Penz


On Jan. 15, 2012, 9:57 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103703/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2012, 9:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> If multiple items are selected and the user presses a mouse button above one of them, he might want to do one of the following:
> 
> 1. Drag and drop all items.
> 2. Open the context menu for all items.
> 3. Trigger the clicked item.
> 
> In the first two cases, all selected items should remain selected. In the third case, only the clicked item should remain selected, and this does not work at the moment.
> 
> My suggested fix adds a new bool member variable that is set to true in KItemListController::mousePressEvent() if an already selected item is left-clicked. It's set to false in KItemListController::mouseMoveEvent() if the selected items are dragged. If that is not the case, the variable is still true, and the selection is cleared in KItemListController::mouseReleaseEvent().
> 
> 
> This addresses bug 290854.
>     http://bugs.kde.org/show_bug.cgi?id=290854
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.h b7efbde 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp d3365ab 
> 
> Diff: http://git.reviewboard.kde.org/r/103703/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120116/b0ce53a0/attachment.htm>