Review Request: middle clicking the 'Home' toolbar button should open the home folder in a new tab

Peter Penz peter.penz19 at gmail.com
Tue Jan 10 11:36:15 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103659/#review9703
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks good :-) I think it is OK to also push it to the 4.8 branch (I'd consider it as a bugfix).

- Peter Penz


On Jan. 10, 2012, 11:17 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103659/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 11:17 a.m.)
> 
> 
> Review request for Dolphin and Peter Penz.
> 
> 
> Description
> -------
> 
> I think consistent behavior is important, so here is the simple patch. 
> 
> 
> This addresses bug 278194.
>     http://bugs.kde.org/show_bug.cgi?id=278194
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 998b6fc 
>   dolphin/src/dolphinmainwindow.cpp 3f527d9 
> 
> Diff: http://git.reviewboard.kde.org/r/103659/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120110/4d8ec4e4/attachment.htm>


More information about the kfm-devel mailing list