Review Request: Rename KFileItemModel::setExpanded() to KFileItemModel::expandParentItems(), fix and simplify the function

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103865/#review10338
-----------------------------------------------------------

Ship it!


Looks very good, thanks!

- Peter Penz


On Feb. 4, 2012, 1:14 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103865/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 1:14 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> This patch makes the following changes to the function KFileItemModel::setExpanded(const QSet<KUrl>& urls):
> 
> 1. Rename to expandParentItems() and make sure that really only the parents are expanded. This fixes a bug in the Folders Panel: If a folder is activated which is not shown in the panel yet, not only its parents, but also the folder itself is expanded.
> 
> 2. Change the argument from a set of URLs to a single URL. The Folders Panel only calls this function for single URLs anyway, and this permits to simplify the function.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h ff816c8 
>   dolphin/src/kitemviews/kfileitemmodel.cpp db9b711 
>   dolphin/src/panels/folders/folderspanel.cpp 2511d7e 
>   dolphin/src/tests/kfileitemmodeltest.cpp c3611ef 
> 
> Diff: http://git.reviewboard.kde.org/r/103865/diff/diff
> 
> 
> Testing
> -------
> 
> Works as expected for me. Unit test added (including a test for https://bugs.kde.org/show_bug.cgi?id=291781, which was about the Folders Panel failing to expand folders whose name contains special characters).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120204/137c5ecf/attachment.htm>