Review Request: Fix crash due to Qthread member variable being deleted before it was finished.

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107656/
-----------------------------------------------------------

(Updated Dec. 24, 2012, 1:13 a.m.)


Review request for Dolphin and Frank Reininghaus.


Summary (updated)
-----------------

Fix crash due to Qthread member variable being deleted before it was finished.


Description
-------

Three commits here:

commit fecc4da9d614b9b3d0924a55e484b34187f0e743
Author: Simeon Bird <spb41 at ias.edu>
Date:   Mon Dec 24 01:02:22 2012 +0000

    When the VersionControlObserver is deleted, its member variable
    m_updateItemStatesThread is deleted too. If it has not yet finished,
    this will lead to a crash.
    
    BUG: 302264
    FIXED-IN: 4.10

commit d35b01694ea8a9e695131d8f59e3e2bfd1863d02
Author: Simeon Bird <spb41 at ias.edu>
Date:   Sun Dec 23 23:45:36 2012 +0000

    The locking around the plugin access in actions doesn't seem to be
    necessary, as actions is only called from the main thread.
    
    Also it wasn't checked consistently; if the lock could not be taken, the
    plugin was accessed anyway.

commit ae54fd78ea17332a60b601f4916b004fa9572fef
Author: Simeon Bird <spb41 at ias.edu>
Date:   Sun Dec 23 23:45:04 2012 +0000

    We don't need the mutex guarding m_itemStates in the
    UpdateItemStatesThread, because m_itemStates is only accessed by the
    when the thread is done, and set before the thread starts.
    
    Also combine the setData function with the constructor.

For real! Probably a fix! I'll test this a bit more to be sure though.


This addresses bug 302264.
    http://bugs.kde.org/show_bug.cgi?id=302264


Diffs
-----

  dolphin/src/views/versioncontrol/updateitemstatesthread.h f0f91d7 
  dolphin/src/views/versioncontrol/updateitemstatesthread.cpp e07d72c 
  dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 42e00de 

Diff: http://git.reviewboard.kde.org/r/107656/diff/


Testing
-------

Compiles, no crash yet. Will test more though.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121224/36b37b4b/attachment.htm>