Review Request: Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107787/#review23688
-----------------------------------------------------------

Ship it!


Thanks Emmanuel, I think that this is the way it should be (at least in the KDE/4.10 branch). When I first read the bug report, I didn't think that we can fix this with a change in just a single line. In fact, my first idea how to solve it would probably have broken other things. Having a group of people discuss about changes in the code really is useful :-)

Note that the KDE/4.10 branch is frozen today for RC 1 tagging according to Albert's recent mail, so the push has to wait until tomorrow.

- Frank Reininghaus


On Dec. 18, 2012, 3:17 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107787/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 3:17 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered which was introduced by commit 9dbc24fd647e0457d50ec901d33100c33967be68
> 
> 
> This addresses bug 311782.
>     http://bugs.kde.org/show_bug.cgi?id=311782
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
> 
> Diff: http://git.reviewboard.kde.org/r/107787/diff/
> 
> 
> Testing
> -------
> 
> "Directory loading has been cancelled" only appears, when the users presses "Stop Loading"
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121218/cc85628d/attachment.htm>