Review Request: Better KMessageWidget integration into Dolphin

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107788/#review23650
-----------------------------------------------------------


Thanks Emmanuel for the patch! In principle, the idea to show all important messages in one single place is nice. But like Christoph and Kai Uwe, I also think that showing messages like "Loading" and "Completed" that don't need the user's attention in the KMessageWidget might be a bit too much.

The widget attracts a lot of attention because it's shown just below the location bar and makes the view contents move down. This is fine for messages about unexpected things like errors, which need the user's attention, but I'm not so sure about other cases.

- Frank Reininghaus


On Dec. 17, 2012, 6:40 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107788/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2012, 6:40 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Use it for all kind of status messages.
> 
> * Display DolphinView::infoMessage(const QString& msg) and DolphinView::operationCompletedMessage(QString) messages in the KMessageWidet (instead of statusbar)
> * Added a new message type MessageType::Success => KMessageWidget::Positive - showSuccessMessage(QString)
> * Hide KMessageWidget on directory loading completed (DolphinViewContainer::slotDirectoryLoadingCompleted()) and on Url change
> 
> The Bugfix for Bug 311782 is also included in this patch - Needs adjustments after the bug 311782 is closed
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h e2d1b18 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
>   dolphin/src/views/dolphinview.cpp 941083f 
> 
> Diff: http://git.reviewboard.kde.org/r/107788/diff/
> 
> 
> Testing
> -------
> 
> Tested and works fine for me
> 
> * Chancing the directory hides the KMessageWidget
> * "Connecting..." message gets hidden after directory loading completed
> 
> 
> Screenshots
> -----------
> 
> Dolphin while connecting
>   http://git.reviewboard.kde.org/r/107788/s/914/
> Dolphin after loading canceled
>   http://git.reviewboard.kde.org/r/107788/s/915/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121218/50472d5d/attachment.htm>