Review Request: Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered

[Frank Reininghaus]

> On Dec. 17, 2012, 9:15 p.m., Frank Reininghaus wrote:
> > Thanks Emmanuel for the patch! And thanks Kai Uwe for watching out for i18n issues - it seems that the "existing translation" is just not there :-(
> > 
> > But now I'm wondering if we need the "Directory loading has been canceled." message at all. If the user clicks the "Stop" button, it's probably sufficient to just clear the status bar's progress text (i.e., m_statusBar->setProgressText(QString()), which we already do now, and also call the status bar's setText(QString) method with an empty string), I think.
> > 
> > What do you think?

Well, maybe we could show the "Directory loading has been canceled." in the status bar, rather than just clearing the status bar, but I think that showing it in the KMessageWidget might be too much. After all, the user knows that he has canceled loading the folder. In any case, we're in hard message freeze for KDE 4.10 already. In principle, one can ask for exceptions, but I'm not sure if the "canceled" message is really important enough - maybe we can just remove it in KDE 4.10 and, optionally, re-add it properly translated in master. IMHO, the main benefit of https://git.reviewboard.kde.org/r/107116/ was that the "Loading Folder..." message is removed.

Just if it wasn't clear why clearing the 'progress text' in the status bar isn't enough: I tried accessing an sftp server and then canceling last night. In that case, there is a non-progress text in the status bar that should also be cleared.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107787/#review23638
-----------------------------------------------------------


On Dec. 17, 2012, 5:02 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107787/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2012, 5:02 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered which was introduced by commit 9dbc24fd647e0457d50ec901d33100c33967be68
> 
> 
> This addresses bug 311782.
>     http://bugs.kde.org/show_bug.cgi?id=311782
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
>   dolphin/src/views/dolphinview.cpp 941083f 
> 
> Diff: http://git.reviewboard.kde.org/r/107787/diff/
> 
> 
> Testing
> -------
> 
> "Directory loading has been cancelled" only appears, when the users presses "Stop Loading"
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121218/0806b2ed/attachment.htm>