Review Request: Better KMessageWidget integration into Dolphin

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Dec 17 18:40:12 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107788/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Use it for all kind of status messages.

* Display DolphinView::infoMessage(const QString& msg) and DolphinView::operationCompletedMessage(QString) messages in the KMessageWidet (instead of statusbar)
* Added a new message type MessageType::Success => KMessageWidget::Positive - showSuccessMessage(QString)
* Hide KMessageWidget on directory loading completed (DolphinViewContainer::slotDirectoryLoadingCompleted()) and on Url change

The Bugfix for Bug 311782 is also included in this patch - Needs adjustments after the bug 311782 is closed


Diffs
-----

  dolphin/src/dolphinviewcontainer.h e2d1b18 
  dolphin/src/dolphinviewcontainer.cpp c27550a 
  dolphin/src/views/dolphinview.cpp 941083f 

Diff: http://git.reviewboard.kde.org/r/107788/diff/


Testing
-------

Tested and works fine for me

* Chancing the directory hides the KMessageWidget
* "Connecting..." message gets hidden after directory loading completed


Screenshots
-----------

Dolphin while connecting
  http://git.reviewboard.kde.org/r/107788/s/914/
Dolphin after loading canceled
  http://git.reviewboard.kde.org/r/107788/s/915/


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121217/ce692137/attachment.htm>


More information about the kfm-devel mailing list