Review Request: Add support for automatically set url location bar to non-editable when focus out

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107748/#review23628
-----------------------------------------------------------


First of all, thanks for the patch! I would not like to add an option for this, but the approach to change back to 'breadbrumb' mode when the 'Editable location bar' setting is set to false looks interesting. I would guess that this satisfies the vast majority of users.

However, I see a problem: when editing the URL and then switching to another application (maybe to look up a directory name), the URL navigator switches back to 'breadcrumb' mode. What's worse, if you un-focus the URL navigator while you're in the middle of entering something, the input is lost.

Maybe it would be better to only switch back to 'breadcrumb' mode after the URL is changed (i.e., when the navigator's urlChanged(QUrl) signal has been received)? This would also make the eventFilter unnecessary.

- Frank Reininghaus


On Dec. 16, 2012, 1:29 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107748/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 1:29 p.m.)
> 
> 
> Review request for Dolphin and Rodrigo Fernandes.
> 
> 
> Description
> -------
> 
> after edit the url the location bar always kept editable is very annoying. since crumb-bread location is much more useful for navigation.
> 
> BTW this is also the default behavior in Finder (Mac FM) AFAIK.
> 
> This patch add support to reset the location bar to non-editable when it's focus out, and also add an option to set it back to the old behavior.
> 
> 
> This addresses bug 157593.
>     http://bugs.kde.org/show_bug.cgi?id=157593
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h e2d1b18 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
> 
> Diff: http://git.reviewboard.kde.org/r/107748/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121217/b803c256/attachment.htm>