Review Request: Add support for automatically set url location bar to non-editable when focus out

[Xuetian Weng]

> On Dec. 17, 2012, 7:57 a.m., Mark Gaiser wrote:
> > dolphin/src/dolphinviewcontainer.h, lines 150-151
> > <http://git.reviewboard.kde.org/r/107748/diff/2/?file=99805#file99805line150>
> >
> >     I don't think you need to reimplement the eventFilter and register the event. Perhaps try the http://qt-project.org/doc/qt-4.8/qwidget.html#focusOutEvent way and see if that works.

The problem is the widget we need to listen to is the KUrlComboBox inside KUrlNavigator, not KUrlNavigator itself (get by "editor()"), but there is no way to replace that widget, so focusOutEvent doesn't work here.

Correct me if my understanding is wrong.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107748/#review23585
-----------------------------------------------------------


On Dec. 16, 2012, 1:29 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107748/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 1:29 p.m.)
> 
> 
> Review request for Dolphin and Rodrigo Fernandes.
> 
> 
> Description
> -------
> 
> after edit the url the location bar always kept editable is very annoying. since crumb-bread location is much more useful for navigation.
> 
> BTW this is also the default behavior in Finder (Mac FM) AFAIK.
> 
> This patch add support to reset the location bar to non-editable when it's focus out, and also add an option to set it back to the old behavior.
> 
> 
> This addresses bug 157593.
>     http://bugs.kde.org/show_bug.cgi?id=157593
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h e2d1b18 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
> 
> Diff: http://git.reviewboard.kde.org/r/107748/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121217/db691caf/attachment.htm>