Review Request: Add support for automatically set url location bar to non-editable when focus out

[Xuetian Weng]

> On Dec. 16, 2012, 2:44 p.m., Mark Gaiser wrote:
> > I strongly recommend reading this bug report before doing anything: https://bugs.kde.org/show_bug.cgi?id=214730
> > Peter closed it because there doesn't seem to be any demand for it.
> > 
> > So i guess it's a decision for Frank to make now.

Well, though my personal sample doesn't reflect the real opinion, but I know nearly all of my friends who using KDE complain on this.
I also suffer this for long time but finally I decide to take some action.. (And I knew the existence of your report, I learnt the ctrl+enter from there)

And at that time there doesn't exist a real patch right? :P


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107748/#review23534
-----------------------------------------------------------


On Dec. 16, 2012, 1:29 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107748/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 1:29 p.m.)
> 
> 
> Review request for Dolphin and Rodrigo Fernandes.
> 
> 
> Description
> -------
> 
> after edit the url the location bar always kept editable is very annoying. since crumb-bread location is much more useful for navigation.
> 
> BTW this is also the default behavior in Finder (Mac FM) AFAIK.
> 
> This patch add support to reset the location bar to non-editable when it's focus out, and also add an option to set it back to the old behavior.
> 
> 
> This addresses bug 157593.
>     http://bugs.kde.org/show_bug.cgi?id=157593
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h e2d1b18 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
> 
> Diff: http://git.reviewboard.kde.org/r/107748/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121217/0f6a8f8a/attachment.htm>