Review Request: [Dolphin] Fake click for short drag and drop on same item

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107708/
-----------------------------------------------------------

(Updated Dec. 14, 2012, 9:25 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Moved all implementation to DragAndDropHelper and call it from the controller (when starting a drag)


Description
-------

When there's a relatively short click (i picked 500ms) and the item is moved to DnD and released on itself, this is now assumed a "dirty click" (ie. the user actually wanted to click, but juddered) instead of presenting a warning that an item cannot be dragged on itself.

Notes:
- 500ms are quite some time. I can drag the icon out, back in and drop it in place.
- due to the high abstraction level in the DnD processing and the application window being the drag source, it is technically possible to split the view and DnD an icon onto its other self within 500ms

I'm however willing to state that if you manage to do either of that, you should not have major issues on performing a regular click either.
I picked the 500ms on personal test (started with 1500, what seems far too much)

- the reason for having the timeout in the first place is the assumption, that users may actually intentionally try to drag an item on itself. Either because they intend to link it there (link recursion can be dangerous, but is a legal action) or for "ummm... i didn't want to copy that folder. errr... how do i stop this ... ok, let's just put it back from where it came and hope for the best". Because of the latter i think this should be hinted after the message freeze.

- one might want to add a "don't ask again" checkbox to the hint and account that by dropping the timeout


This addresses bugs 283646, 297414, 307747, and 311483.
    http://bugs.kde.org/show_bug.cgi?id=283646
    http://bugs.kde.org/show_bug.cgi?id=297414
    http://bugs.kde.org/show_bug.cgi?id=307747
    http://bugs.kde.org/show_bug.cgi?id=311483


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistcontroller.cpp 697e04f 
  dolphin/src/views/draganddrophelper.h ac16f7c 
  dolphin/src/views/draganddrophelper.cpp f81d4d0 

Diff: http://git.reviewboard.kde.org/r/107708/diff/


Testing
-------

clickdragged a folder in both view (w/ and w/o scroll offset)


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121214/f0555db3/attachment.htm>