Review Request: Bug 287829 - inline rename multiple files does not honour sort order

[Emmanuel Pescosta]

> Does this mean that the file jumps away when you press Enter, after
inline-
> renaming?

This patch doesn't change the inline-renaming behavior. When you rename
multiple files, than the Rename-Dialog is used for that instead. (The title
of the bug is a little bit wrong ... "inline" should be removed)

For example multiple files A (1.2.2007), B (1.2.2004), C (1.2.2011), D
(1.2.2012) with different creation dates:
a. Ordered by name:  A, B, C, D -> Rename with "x#" => x1 (1.2.2007), x2
(1.2.2004), x3 (1.2.2011), x4 (1.2.2012)
b. Ordered by date: B, A, C, D -> Rename with "x#" => x1 (1.2.2004), x2
(1.2.2007), x3 (1.2.2011), x4 (1.2.2012)

So the result:
Nope the don't jump away, because the sort ordering is the same (In example
a. and b.)


2012/12/14 Thiago Macieira <thiago at kde.org>

> On sexta-feira, 14 de dezembro de 2012 13.46.44, Emmanuel Pescosta wrote:
> > Description
> > -------
> >
> > Fix Bug 287829 - inline rename multiple files does not honour sort order
> >
> > * Removed the complete sort code in RenameDialog::renameItems()
> > * Sort items by indexes in DolphinView::selectedItems()
>
> Does this mean that the file jumps away when you press Enter, after inline-
> renaming?
>
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>       PGP/GPG: 0x6EF45358; fingerprint:
>       E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121214/828c7391/attachment.htm>