Review Request: Bug 287829 - inline rename multiple files does not honour sort order

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107718/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Fix Bug 287829 - inline rename multiple files does not honour sort order 

* Removed the complete sort code in RenameDialog::renameItems()
* Sort items by indexes in DolphinView::selectedItems()


This addresses bug 287829.
    http://bugs.kde.org/show_bug.cgi?id=287829


Diffs
-----

  dolphin/src/views/dolphinview.cpp 941083f 
  dolphin/src/views/renamedialog.cpp a91f91b 

Diff: http://git.reviewboard.kde.org/r/107718/diff/


Testing
-------

Created some items with: touch -d 2012-01-01 c; touch -d 2012-02-01 e; touch -d 2012-03-01 a; touch -d 2012-04-01 d; touch -d 2012-05-01 b

Tested with different sort orders (Sort by name, date, ...) -> Everything worked fine for me ;)

Passed all 7 tests


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121214/a3211095/attachment.htm>