Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected

[Frank Reininghaus]

> On Dec. 13, 2012, 7:04 p.m., David Faure wrote:
> > dolphin/src/views/dolphinview.cpp, line 796
> > <http://git.reviewboard.kde.org/r/107305/diff/3/?file=98834#file98834line796>
> >
> >     Surely this should call i18n() around the question?
> >     
> >     (the bug was in the initial version of the code, but still)

Thanks David, good catch! I've just fixed this in master (it's still OK to do that until the hard message freeze kicks in in a few days if I read the 'Schedules' page on techbase correctly).


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107305/#review23431
-----------------------------------------------------------


On Dec. 13, 2012, 4:04 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107305/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 4:04 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected
> 
> 
> This addresses bug 304299.
>     http://bugs.kde.org/show_bug.cgi?id=304299
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.h e5693b3 
>   dolphin/src/dolphinpart.cpp ccc91fd 
>   dolphin/src/dolphinviewcontainer.h 0300273 
>   dolphin/src/dolphinviewcontainer.cpp 6e99437 
>   dolphin/src/views/dolphinview.h 6d15ebf 
>   dolphin/src/views/dolphinview.cpp ea64a04 
> 
> Diff: http://git.reviewboard.kde.org/r/107305/diff/
> 
> 
> Testing
> -------
> 
> Tested with Gwenview, works fine.
> 
> # Dolphin 2.1: Start one Gwenview instance for each selected image
> # Patched Dolphin: Open all selected images in one Gwenview instance
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121213/0c675dfc/attachment.htm>