Review Request: Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/#review23375
-----------------------------------------------------------


Thanks for the new patch! The Dolphin side looks very nice from my point of view. Maybe I would put the connect in DolphinView::pasteToUrl(const KUrl& url) on a single line (splitting might not improve readability all that much, and dolphinview.cpp has enough lines already). But this is a matter of taste, I think.

I think it would be nice if the same thing could also be done when files are dropped, because the same issue applies also to that case. But better wait until David says something about the lib/konq part of the patch.

- Frank Reininghaus


On Dec. 11, 2012, 10:59 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107351/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2012, 10:59 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names)
> 
> Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
> 
> 
> This addresses bug 233335.
>     http://bugs.kde.org/show_bug.cgi?id=233335
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 6d15ebf 
>   dolphin/src/views/dolphinview.cpp ea64a04 
>   lib/konq/konq_operations.h b82feb4 
>   lib/konq/konq_operations.cpp e0f1ade 
> 
> Diff: http://git.reviewboard.kde.org/r/107351/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a test folder with Dolphin.
> 2. Create the test files:
>     2.1. Open Dolphin’s terminal (F4).
>     2.2. Run “mkdir folder ; touch a b folder/b c d”.
>     2.3. Close Dolphin’s terminal (F4).
> 3. In the current folder, select the four empty files (a, b, c, d) and copy them (Ctrl+C).
> 4. Enter the “folder” folder.
> 5. Paste the files (Ctrl+V).
>     5.1. When asked for a new name for “b”, enter “b2” and hit Enter to continue.
> 
> Result:
> Items “a”, “b2”, “c”, “d” are selected
> 
> Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121212/62a77f31/attachment.htm>