Review Request: Fix two renaming bugs (When the new file name includes slashes)

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107681/#review23374
-----------------------------------------------------------

Ship it!


Thanks Emmanuel! Looks good, please push to 4.9.

- Frank Reininghaus


On Dec. 12, 2012, 8:13 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107681/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 8:13 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives unclear error message 
> Fix Bug 308597 - Regression: Renaming a file/folder to something that contains a "/" will result in several message boxes
> 
> Uses the same solution as Dolphin-Rename-Dialog does. (KIO::encodeFileName)
> 
> 
> This addresses bugs 240820 and 308597.
>     http://bugs.kde.org/show_bug.cgi?id=240820
>     http://bugs.kde.org/show_bug.cgi?id=308597
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 1e4b5fd 
> 
> Diff: http://git.reviewboard.kde.org/r/107681/diff/
> 
> 
> Testing
> -------
> 
> Renaming of files works fine.
> 
> Included slashes are correctly replaced by fraction slashes.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121212/d3482950/attachment.htm>