Review Request: Fix bookmarks "Recently Accessed" and "Search for" not available with default install

[Luc Menut]

> On Nov. 26, 2012, 7:21 p.m., Frank Reininghaus wrote:
> > Thanks Luc for debugging this! In principle, I would say that this makes sense. However, I've just tried "grep Service-nepomukfileindexer * -r" in my KDE source directory and found quite a few places in Dolphin and kdelibs where this might need to be changed as well. But keeping that default value 'true' in so many different places looks very inconvenient from a maintenance point of view to me. Isn't there a better solution for this? I must admit that I'm not too familiar with KConfig* - in Dolphin, we auto-generate the settings classes from *.kcfg files, which have default values in them which can be used everywhere. This might not be be best approach for the Nepomuk settings, but I'm still wondering if we can avoid hard-coding the default value in so many different files.
> > 
> > Moreover, I'm quite puzzled that this hasn't been reported earlier. If this is broken since f5b6fbf7, this means that this has *never* worked because that commit was before the first stable release which contains the new Places Panel.
> 
> Luc Menut wrote:
>     I understand the maintenance point of view. I have no idea on the best way to fix this.
>     
>     While looking at bug 304323, I found that this issue is mentionned in a comment 
>       https://bugs.kde.org/show_bug.cgi?id=304323#c14
>     
>     I'm not surprized that there isn't specific bug report if this has never worked; users doesn't report bug for features that they don't know, that they have never seen ;-)
>     I found these nice feature by chance because I have temporarily disabled indexing on one system. When I re-enabled indexing, these bookmarks appeared.
> 
> Frank Reininghaus wrote:
>     Yes, you're probably right about that comment.
>     
>     Well, I'm not sure if there is a better way to fix this without messing around too much with Nepomuk's configuration. In any case, this "default settings maintenance" problem has always been there, your proposal is unrelated to that. If nobody has a better idea, I'm OK if this is pushed to 4.9, preferably after creating a bug report about the problem to make sure that the fix appears in the 4.9.4 changelog. Luc, can you file a bug report at bugs.kde.org? I'll push your fix tomorrow then. Thanks again for your help!

Thanks to have submitted this fix, and sorry for the delay (currently, I don’t have much free time).
What about the other places where you found the same problem. Shouldn't we fix all of them? or do you plan a better fix?


- Luc


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107464/#review22590
-----------------------------------------------------------


On Nov. 25, 2012, 7:24 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107464/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 7:24 p.m.)
> 
> 
> Review request for Dolphin, Vishesh Handa, Peter Penz, and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The bookmarks for "Recently Accessed" and "Search for" is not available in dolphin after a default install, since git rev. f5b6fbf7
>   https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/f5b6fbf7747cefceef4bcd31d90d053da5c560c4
> 
> With a default install, indexing is enabled by default and [Service-nepomukfileindexer]autostart is not written in nepomukserverrc.
>   https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/nepomuk/kcm/nepomukserverkcm.cpp#L216
> 
> Because in dolphin, placesitemmodel.cpp line 93 
>   m_fileIndexingEnabled = config.group("Service-nepomukfileindexer").readEntry("autostart", false)
> default to false if [Service-nepomukfileindexer]autostart is missing, m_fileIndexingEnabled is false by default even if indexing is available.
> 
> m_fileIndexingEnabled should follow the default value (true) of nepomukserverkcm m_checkEnableFileIndexer.
> 
> The suggested patch fixes this issue.
> 
> regards,
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp a37c17f 
> 
> Diff: http://git.reviewboard.kde.org/r/107464/diff/
> 
> 
> Testing
> -------
> 
> tested with KDE 4.9.80 (Mageia Cauldron)
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121203/68b27868/attachment.htm>