Review Request: Show removable media in Dolphin's "Copy To" and "Move To" context menus

[Rajeesh K Nambiar]

> On Dec. 4, 2012, 12:11 p.m., Frank Reininghaus wrote:
> > First of all, thanks for the patch and sorry for the late response. I was not aware of your request before today (I was not responsible for reviewing Dolphin patches last year, and moreover, it's not really a Dolphin issue).
> > 
> > You might want to add David Faure to this request, he is responsible for lib/konq.
> > 
> > About the implementation: There is the risk that loading the 'Places' takes very long (e.g., if there are optical drives or slow USB devices), so it could be that the entire application is frozen for quite some time before the menu is opened. There is some ongoing work to provide a solution for this which might become part of kdelibs in KDE 4.10:
> > 
> > https://git.reviewboard.kde.org/r/107513/

Thanks for the response, Frank. Added dfaure to the review now.

I was in fact thinking about this review when I saw the above udisks2 review few days ago. Real life work has not allowed me to progress much on this, but I tried using KPlaces{Item,Model} et al few weeks ago, but debugging was hard and left there. Till I find a way to use KFilePlacesModel, I was planning to reprise this patch as in the first version.


- Rajeesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102657/#review22965
-----------------------------------------------------------


On Sept. 22, 2011, 7:30 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102657/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2011, 7:30 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> The most common usage for "{Copy,Move} To" dolphin context menus is that a user wants to copy/move a selected file to plugged in USB drive. Show the mounted removable media also along with "Root Folder" and recently used entries.
> 
> It would be nice to have "Places" sidebar instead of the current implementation, which includes Root Folder, Home Folder, Desktop Folder, other drives including removable media like USB drives etc. See bugs 140475, 251151 et al. This should also help in scenario where plugged in removable media is not automatically mounted (which is the default setup at least in Fedora). I couldn't find a way to easily extend that functionality, though.
> 
> 
> This addresses bug 251151.
>     http://bugs.kde.org/show_bug.cgi?id=251151
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_copytomenu.cpp ca1d963 
> 
> Diff: http://git.reviewboard.kde.org/r/102657/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user.
> 
> 
> Screenshots
> -----------
> 
> Places without Devices
>   http://git.reviewboard.kde.org/r/102657/s/268/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121204/b7c5f4ad/attachment.htm>