Review Request: Fixes Bugs 242007, 293200 and 305783

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106271/#review18332
-----------------------------------------------------------


Thanks for looking into these issues and for the patch! And thanks for noticing the Folders Panel expansion problem in the first place.

I agree that the Folders Panel issues should be fixed, but I'm not so sure about opening folders in the view which have been hovered while dragging something to the Places Panel. This would be a behaviour change which might not be suitable for a stable branch. And I'm not really sure if this would be very useful at all, I have to check how other file managers do it.

About updating the auto activation in the Folders Panel when the settings are changed: I agree that this would make Dolphin's behaviour more consistent, and first I thought that this is a very good idea. But then I tried an older Dolphin version (with the old, Qt itemview-based Folders Panel implementation) and noticed that folders were always expanded in that panel even there, no matter what the 'open folders during drag operations' setting is. It's been like that in every Dolphin version so far, which makes me wonder if some people actually rely on that behaviour. Moreover, we never had any complaints about this, so I think it would be safer to always expand folders in the Folders Panel when hovering them with something that has been dragged. This would also mean that we don't need the additions to DolphinMainWindow, which is a very complex class already.

What do you think?

- Frank Reininghaus


On Aug. 30, 2012, 5:55 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106271/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 5:55 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin
> 
> Fixes Bug 242007 - "Open Folder during Drag operation" cannot go into different partition using "Places Pane
> 
> Fixes Bug 305783 - dragging a file over a directory
>      does not expand the dir => Bug discovered: When you drag a
>      item onto a folder-view-item and then move it away
>      instantly before the autoactivation event is triggered
>      (After 750ms), the folder will be opened anyway.
> 
> 
> This addresses bugs 242007, 293200 and 305783.
>     http://bugs.kde.org/show_bug.cgi?id=242007
>     http://bugs.kde.org/show_bug.cgi?id=293200
>     http://bugs.kde.org/show_bug.cgi?id=305783
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h ab79fb0 
>   dolphin/src/dolphinmainwindow.cpp d83c9de 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
>   dolphin/src/panels/folders/folderspanel.h 14d8e87 
>   dolphin/src/panels/folders/folderspanel.cpp 0760200 
>   dolphin/src/panels/panel.h 064e1f3 
>   dolphin/src/panels/panel.cpp c2681ec 
>   dolphin/src/panels/places/placespanel.h 8a84e00 
>   dolphin/src/panels/places/placespanel.cpp d445088 
> 
> Diff: http://git.reviewboard.kde.org/r/106271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120831/1de6b759/attachment.htm>